Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: Add commit template #12212

Closed
wants to merge 2 commits into from
Closed

Conversation

jlucovsky
Copy link
Contributor

Continuation of #11512

Issue: none

This commit adds a template that identifies commit message elements that we find important. The Suricata development team requests that contributions use the template to help improve commit messages. We reserve the right to strictly enforce adherence to the template in the future.

Configure git to use this template with:
git config commit.template ..github/commit-template.txt

Describe changes:

  • Add commit template with instructions on how to configure

Updates:

  • Removed junk file

Provide values to any of the below to override the defaults.

  • To use an LibHTP, Suricata-Verify or Suricata-Update pull request,
    link to the pull request in the respective _BRANCH variable.
  • Leave unused overrides blank or remove.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

Issue: none

This commit adds a template that identifies commit message elements that
we find important. The Suricata development team requests that
contributions use the template to help improve commit messages. We
reserve the right to strictly enforce adherence to the template in the
future.

Configure git to use this template with:
    git config commit.template ..github/commit-template.txt
Describe how to use the git commit template. The template helps ensure
that the information needed for evaluation and context is included in
the commit message.

Ticket: <Redmine ticket number>
@jlucovsky jlucovsky requested review from jufajardini and a team as code owners December 3, 2024 14:07
@victorjulien victorjulien added this to the 8.0 milestone Dec 17, 2024
@victorjulien
Copy link
Member

Merged in #12314, thanks!

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.14%. Comparing base (5d766df) to head (4b253c3).
Report is 81 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #12212       +/-   ##
===========================================
+ Coverage   62.68%   75.14%   +12.46%     
===========================================
  Files         840      851       +11     
  Lines      153669   155606     +1937     
===========================================
+ Hits        96323   116931    +20608     
+ Misses      57346    38675    -18671     
Flag Coverage Δ
fuzzcorpus 61.01% <ø> (?)
livemode 19.41% <ø> (?)
pcap 44.39% <ø> (?)
suricata-verify 62.76% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants